Skip to content

New upstream fields#906

Open
BrutuZ wants to merge 1 commit intobeeequeue:mainfrom
BrutuZ:new-fields
Open

New upstream fields#906
BrutuZ wants to merge 1 commit intobeeequeue:mainfrom
BrutuZ:new-fields

Conversation

@BrutuZ
Copy link

@BrutuZ BrutuZ commented Jan 24, 2026 •
edited
Loading

Fribb recently updated the lists generator, this PR aligns the output with the new output

This includes introducing a few new fields, remapping thetvdb that was renamed to tvdb and thus failing to match (removed on rebase after b47c3b6), as well as retiring notify-moe.

I couldn't get .alterTable() to work, hence opting to drop the entire table and recreate it on the DB migration. Didn't seem like much of a problem since it's always repopulated anyway

Before Changes (Live)

{
  "anidb": 5458,
  "anilist": 3390,
  "anime-planet": "amuri-in-star-ocean",
  "anisearch": 4445,
  "imdb": null,
  "kitsu": 2977,
  "livechart": 7110,
  "notify-moe": null,
  "themoviedb": 44298,
  "thetvdb": null,
  "myanimelist": 3390
}
{
  "anidb": 5459,
  "anilist": 3269,
  "anime-planet": "hack-g-u-trilogy",
  "anisearch": 4491,
  "imdb": "tt1164545",
  "kitsu": 2895,
  "livechart": 4721,
  "notify-moe": null,
  "themoviedb": 8864,
  "thetvdb": null,
  "myanimelist": 3269
}

After Changes

{
  "anidb": 5458,
  "anilist": 3390,
  "anime-planet": "amuri-in-star-ocean",
  "anisearch": 4445,
  "imdb": null,
  "kitsu": 2977,
  "livechart": 7110,
  "animenewsnetwork": 8720,
  "themoviedb": 44298,
  "themoviedb-season": 1,
  "thetvdb": 91021,
  "thetvdb-season": 1,
  "myanimelist": 3390,
  "simkl": 40868,
  "animecountdown": 40868,
  "media": "OVA"
}
{
  "anidb": 5459,
  "anilist": 3269,
  "anime-planet": "hack-g-u-trilogy",
  "anisearch": 4491,
  "imdb": "tt1164545",
  "kitsu": 2895,
  "livechart": 4721,
  "animenewsnetwork": 8719,
  "themoviedb": 8864,
  "themoviedb-season": null,
  "thetvdb": 79099,
  "thetvdb-season": null,
  "myanimelist": 3269,
  "simkl": 41283,
  "animecountdown": 41283,
  "media": "MOVIE"
}

@BrutuZ BrutuZ mentioned this pull request Jan 27, 2026
Open
@BrutuZ BrutuZ changed the title Update fields from Fribb's anime-lists Fix TVDB and add new upstream fields Jan 31, 2026
@BrutuZ BrutuZ changed the title Fix TVDB and add new upstream fields Add new upstream fields Feb 18, 2026
@BrutuZ
Copy link
Author

BrutuZ commented Feb 18, 2026

Rebased to address merge conflicts from b47c3b6
Ready for review @beeequeue

beeequeue
beeequeue requested changes Feb 18, 2026
View reviewed changes
Copy link
Owner

@beeequeue beeequeue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the effort, but this pr is too big to understand and merge at once. i would recommend splitting it into pieces

  • changing the source json file, explaining the differences between them
  • removal of the old fields
  • adding new fields
    • if any of these are not 1-to-1 mappings they also need new endpoints to fetch them, like tvdb has

i can probably do it if you dont have time. :)

@BrutuZ
Copy link
Author

BrutuZ commented Feb 18, 2026 •
edited
Loading

  • The update to the documentation and tests really blew up the PR's line and file count 😅
  • The JSON has the same structure, just changed it due to the minor savings (a whopping ~50Kb 😆) of the minified / non pretty-print version. Not sure if it was previously available or a new introduction from Fribb's recent update to the generator.
  • The only non-unique fields (seasons and media type) introduced (AFAIK) would make little sense to have the reverse search since there's no relation, unlike the mentioned ones from anime-lists
  • I could also remove the DB migration on dev environment. Was useful while testing the schema updates

@BrutuZ
Copy link
Author

BrutuZ commented Feb 19, 2026

Okay, I did split it in the 3 steps you described, but separate PRs means it will require your intervention because there will be merge conflicts and an extraneous and permanently empty notify-moe column in the database due to the separation of its removal and the new migration for new fields

@BrutuZ BrutuZ changed the title Add new upstream fields New upstream fields and more Feb 19, 2026
This was referenced Feb 19, 2026
Open
Open
@BrutuZ BrutuZ changed the title New upstream fields and more New upstream fields Feb 19, 2026
@BrutuZ
Copy link
Author

BrutuZ commented Feb 19, 2026

Force-pushed only the addition of new fields to this PR since I can only edit the target branch, not the origin.
Should you change your mind and decide the all-in-one approach is easier, I've kept that commit on https://github.com/BrutuZ/arm-server/tree/new-fields-full

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeequeue beeequeue beeequeue requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrutuZ @beeequeue

Comments